Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete lines 6-8 on package.json related to Bower #5060

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Delete lines 6-8 on package.json related to Bower #5060

merged 1 commit into from
Mar 18, 2019

Conversation

emestabillo
Copy link
Contributor

@emestabillo emestabillo commented Mar 14, 2019 •
edited by sashadev-sky
Loading

Fixes #5037 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • PR is descriptively titled 📑
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Mar 14, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
Also, can you tell us your Twitter handle so we can thank you properly?

@emestabillo
Copy link
Contributor Author

Hi @gauravano @sashadev-sky! Kindly review and let me know if I need to incorporate changes. Thank you!

@siaw23-retired
Copy link
Collaborator

Hi @emestabillo... I'm wondering why you're removing this...?

@grvsachdeva
Copy link
Member

Hi @siaw23, check out #5037. Thoughts?

@sashadev-sky
Copy link
Member

@siaw23 via #4849 we're removing it because we're no longer using bower in our setup and it creates symlinks to bower components

@sashadev-sky
Copy link
Member

@emestabillo hi, this looks good to me! You are receiving a travis error because our travis testing setup still invokes a postinstall script and now there is no longer one. To fix this, you will need to remove yarn postinstall from a few additional lines:

plots2/install_cloudnine.sh

Line 11 in 6d10661

yarn install && yarn postinstall

plots2/Dockerfile

Line 39 in 6d10661

RUN yarn install && yarn postinstall && yarn upgrade

plots2/.travis.yml

Line 25 in 6d10661

- docker-compose exec web yarn --ignore-engines --ignore-scripts --modules-folder ./public/lib && yarn postinstall

Then you should be all set! Let me know if you have any questions.

@sashadev-sky
Copy link
Member

mentioning @Souravirus because he works with Docker configs

@emestabillo
Copy link
Contributor Author

Hi @sashadev-sky, I made the changes requested but still getting a build error. Please advise. Thank you!!

@Souravirus
Copy link
Member

Hi @emestabillo, the error is coming as you have removed the whole lines. You just had to remove the postinstall command from those commands. You have to keep those lines though.
Thank you!!

@plotsbot
Copy link
Collaborator

plotsbot commented Mar 17, 2019 •
edited
Loading

2 Messages
📖 @emestabillo Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@emestabillo
Copy link
Contributor Author

Hi @emestabillo, the error is coming as you have removed the whole lines. You just had to remove the postinstall command from those commands. You have to keep those lines though.
Thank you!!

Thank you for the tip @Souravirus !! 🎉

@Souravirus
Copy link
Member

No problem @emestabillo. Just wanted to say try to rebase the commits than merging it, because the changes which are done by others are also mixed up with yours.
Thank you!!

@emestabillo
Copy link
Contributor Author

Hi @Souravirus , I hope I did this correctly. I'm a newbie with a complicated rebase. Thank you once again!

@Souravirus
Copy link
Member

Wow nice work @emestabillo.

sashadev-sky
sashadev-sky approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@sashadev-sky sashadev-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@sashadev-sky
Copy link
Member

@Souravirus could you leave a review please so we can ping jeff to get it merged next

@Souravirus
Copy link
Member

Hi @emestabillo, can you post these changes to unstable? Just to make sure everything's OK?
Thank you!!

@emestabillo
Copy link
Contributor Author

emestabillo commented Mar 18, 2019 •
edited
Loading

Hi @Souravirus , just to clarify: did you mean change the branch where it will be merged from ‘master’ to ‘unstable’ ?

@grvsachdeva
Copy link
Member

Hi @emestabillo, actually we have unstable.publiclab.org where we test our work. It builds from unstable branch. @Souravirus actually only some people have push access to unstable so I am pushing this PR to unstable for testing. Thanks!

@grvsachdeva
Copy link
Member

Build completed smoothly 👍 . Great work @emestabillo. Thanks everyone 💯 !

@grvsachdeva grvsachdeva mentioned this pull request Mar 18, 2019
Merged
5 tasks
@Souravirus
Copy link
Member

Thanks @gauravano for your help

@emestabillo
Copy link
Contributor Author

Thank you everyone @gauravano @Souravirus @sashadev-sky!!

@jywarren
Copy link
Member

Great work!!! And thanks everyone for a good collaboration! 🎉 🙌

@jywarren jywarren merged commit d89abb2 into publiclab:master Mar 18, 2019
@welcome
Copy link

welcome bot commented Mar 18, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

icarito pushed a commit to icarito/plots2 that referenced this pull request Apr 9, 2019
@emestabillo @icarito
Remove yarn installs (publiclab#5060)
0523b64
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@emestabillo @jywarren
Remove yarn installs (publiclab#5060)
8593dac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashadev-sky sashadev-sky sashadev-sky approved these changes

@Souravirus Souravirus Souravirus approved these changes

@jywarren jywarren Awaiting requested review from jywarren

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@emestabillo @siaw23-retired @grvsachdeva @sashadev-sky @Souravirus @plotsbot @jywarren